drop logback dependency in favor of only using slf4j-api #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops the logback dependency in favor of
slf4j-api1.7.25which provides the underlying interface oforg.slf4j.LoggerFactory. No code changes are required since everything already uses that interface.This change allows consumers of
logger4sto choose a different logging back-end.In particular this avoids a common problem when a project brings in multiple components with differing logging framework, resulting in multiple bindings problem.
This change also allows libraries to depend on
logger4swithout propagating a potentially unwanted logback dependency.