Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional aliasis #792

Closed
wants to merge 1 commit into from
Closed

add additional aliasis #792

wants to merge 1 commit into from

Conversation

b4ldr
Copy link
Collaborator

@b4ldr b4ldr commented Jul 12, 2017

Add additional types to standard lib for

  • Stdlib::Port: all valid TCP/UDP ports
  • Stdlib::Privilegedport: ports which need root power to bind
  • Stdlib::Unprivilegedport: ports which do not need root power
  • Stdlib::Fileuri: match file:///path/to/file
  • Stdlib::Puppeturi: match puppet:///modules/path/to/file
  • Stdlib::Puppetsource: matches values that can be used for a file type source parameter
  • Stdlib::Puppetcontent: matches values that can be used for a file type content parameter
  • Stdlib::Base64: matches base64 strings
  • Stdlib::Base32: matches base64 strings
  • Stdlib::Fqdn: loose check for a fully qualified domain name
  • Stdlib::Host: fqdn or ip address

i think the port types originally came from voxpupuli/puppet-tea so can remove them if desired. it seems i [icann-dns/puppet-tea] and voxpupuli/puppet-tea have also implemented some syslog types would you be intrested in adding them or a variation their of?

I would also be keen to move the IP and other compat functions to the Stdlib level. i.e. Stdlib::Ip_address instead of Stdlib::Compat::Ip_address . just simply because the latter is getting on the large side. would be happy to to the work just wondered if there is philosophical objections to doing something like

type Stdlib::Ip_address = Stdlib::Compat::Ip_address

@b4ldr
Copy link
Collaborator Author

b4ldr commented Sep 27, 2017

any feedback on this?

@b4ldr
Copy link
Collaborator Author

b4ldr commented Nov 13, 2017

i have split this up so that its easier to review. please see #839 #840 #841 #842 #843

@b4ldr b4ldr closed this Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants