Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional types to standard lib for
Stdlib::Port
: all valid TCP/UDP portsStdlib::Privilegedport
: ports which need root power to bindStdlib::Unprivilegedport
: ports which do not need root powerStdlib::Fileuri
: match file:///path/to/fileStdlib::Puppeturi
: match puppet:///modules/path/to/fileStdlib::Puppetsource
: matches values that can be used for a file type source parameterStdlib::Puppetcontent
: matches values that can be used for a file type content parameterStdlib::Base64
: matches base64 stringsStdlib::Base32
: matches base64 stringsStdlib::Fqdn
: loose check for a fully qualified domain nameStdlib::Host
: fqdn or ip addressi think the port types originally came from voxpupuli/puppet-tea so can remove them if desired. it seems i [icann-dns/puppet-tea] and voxpupuli/puppet-tea have also implemented some syslog types would you be intrested in adding them or a variation their of?
I would also be keen to move the IP and other compat functions to the Stdlib level. i.e.
Stdlib::Ip_address
instead ofStdlib::Compat::Ip_address
. just simply because the latter is getting on the large side. would be happy to to the work just wondered if there is philosophical objections to doing something like