Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release prep v9.4.1 #1407

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Release prep v9.4.1 #1407

merged 1 commit into from
Nov 9, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Nov 8, 2023

Automated release-prep through pdk-templates from commit 44c298c.
Please verify before merging:

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct.

REFERENCE.md Outdated
Comment on lines 10 to 11
* [`stdlib::manage`](#stdlibmanage): A simple place to define trivial resources
* [`stdlib::stages`](#stdlibstages): This class manages a standard set of run stages for Puppet. It is managed by
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This the output of an old puppet-strings. I think the GitHub Action is doing something wrong here, perhaps use an outdated container.

CHANGELOG.md Outdated
Comment on lines 16 to 18
### Other

- Remove unused parser deprecation function [#1392](https://github.com/puppetlabs/puppetlabs-stdlib/pull/1392) ([ekohl](https://github.com/ekohl))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder where this went.

@ekohl
Copy link
Collaborator

ekohl commented Nov 8, 2023

I manually fixed this up. Getting this bugfix release out would help me a lot.

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as it is now (I did not see the previous version that was fixed by @ekohl so can't help with what was wrong).

@ekohl
Copy link
Collaborator

ekohl commented Nov 8, 2023

See some outdated comments. It generated the REFERENCE.md file with an older puppet-strings so it reverted a lot of changes. It also made a lot of changes to the changelog, so I only kept the ones in that add 9.4.1 (and fix the date on 9.4.0).

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit weird to approve a PR I created, but I certainly don't want changes.

@bastelfreak bastelfreak merged commit 6038c77 into main Nov 9, 2023
37 of 43 checks passed
@bastelfreak bastelfreak deleted the release-prep branch November 9, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants