Fixing rubocop failure #1398
Merged
Fixing rubocop failure #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajat-puppet
requested review from
alexjfisher,
b4ldr,
bastelfreak,
ekohl,
smortex,
seanmil and
a team
as code owners
ekohl
requested changes
Sep 27, 2023
There was a problem hiding this comment.
Please use the imperative mood when writing commit messages. So Fix instead of Fixing.
| @@ -114,7 +114,7 @@ RSpec/ExampleLength: | |||
| # Offense count: 2 | |||
| # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly. | |||
| # Include: **/*_spec*rb*, **/spec/**/* | |||
| RSpec/FilePath: | |||
| RSpec/SpecFilePathSuffix: | |||
There was a problem hiding this comment.
Please fix these instead by renaming the files to have a _spec.rb suffix. The cop tells you the tests in those files aren't executed right now.
|
And don't merge your own PRs in 2 minutes after opening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing rubocop failure
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)