(#1556) Fix Python package name for Ubuntu >= 22.04 #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antaflos
requested review from
alexjfisher,
bastelfreak,
deric,
ekohl,
SimonHoenscheid,
smortex and
a team
as code owners
ekohl
previously approved these changes
Nov 23, 2023
manifests/params.pp
Outdated
| @@ -159,7 +159,12 @@ | |||
| $perl_package_name = pick($perl_package_name, 'libdbd-pg-perl') | |||
| $plperl_package_name = pick($plperl_package_name, "postgresql-plperl-${version}") | |||
| $plpython_package_name = pick($plpython_package_name, "postgresql-plpython-${version}") | |||
| $python_package_name = pick($python_package_name, 'python-psycopg2') | |||
|
|
|||
| if $facts['os']['name'] == 'Ubuntu' and versioncmp($facts['os']['release']['full'], '22.04') >= 0 { | |||
There was a problem hiding this comment.
Looks like the same is needed at least for Debian 12. For Debian 11 there still is python-psycopg2 as well as python3-psycopg2. Would you mind doing the same for Debian >= 12 at least while you're at it?
There was a problem hiding this comment.
I have added such a test for Debian 12 as well, trying to make the logic somewhat readable. Not sure if this is in tune with the module's coding style though.
…ian 12 For Ubuntu 22.04 and Debian 12 and later the Python PostgreSQL package is called "python3-psycopg2" so make that distinction in params.pp.
antaflos
force-pushed
the
fix_python_package_ubuntu_jammy
branch
from
f02d33c
to
9d4fc30
Compare
ekohl
approved these changes
Nov 24, 2023
|
I don't see how the failing checks are related so I'm merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For Ubuntu 22.04 and later the Python PostgreSQL package is called "python3-psycopg2" so make that distinction in params.pp.
Additional Context
This is missing spec tests but apparently there are no examples for Ubuntu past 18.04 so not sure where I would add tests to cover this change.
Related Issues (if any)
Fixes #1556
Checklist
puppet apply)