server::database_grant: Always set default user/group and expose port as parameter #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
requested review from
alexjfisher,
deric,
ekohl,
SimonHoenscheid,
smortex and
a team
as code owners
bastelfreak
force-pushed
the
database_grant
branch
4 times, most recently
from
6232171
to
43861a3
Compare
ekohl
reviewed
Aug 31, 2023
|
@ekohl It's already broken because the defined resource postgresql::server::grant has a port param with a default value and won't use |
|
@ekohl I could reverse the logic and always use $connect_settings when it's not empty? |
bastelfreak
force-pushed
the
database_grant
branch
from
43861a3
to
169b358
Compare
SimonHoenscheid
previously approved these changes
Aug 31, 2023
bastelfreak
force-pushed
the
database_grant
branch
4 times, most recently
from
f4f2361
to
4304371
Compare
This enables us to make it configureable. When a user doesn't specify it, the defaults will be passed, without breaking existing behaviour.
bastelfreak
force-pushed
the
database_grant
branch
from
4304371
to
56fa971
Compare
bastelfreak
changed the title
|
I made the port optional, so this should be fine now |
SimonHoenscheid
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to make it configureable. When a user doesn't specify it, the defaults will be passed, without breaking existing behaviour.