Add new ini_section type #537
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
force-pushed
the
524-add-ini_section
branch
from
3541b95 to
bf19405
Compare
smortex
force-pushed
the
524-add-ini_section
branch
2 times, most recently
from
8894ed7 to
fd331f1
Compare
3 tasks
PR #532 introduced 4ebe030 which breaks backwards compatibility and is part of a patch release, as reported here: #532 (comment) This reverts commit 4ebe030. This will allow us to do a new patch release that fix the unexpected backwards incompatible change, and leave the room to implement this as part of a next major version of the module.
When the last setting of a section was removed, the whole section was removed unless it contained white space of comments. In #532, this was changed to also remove sections that only contained space (blank lines), but it caused regressions and was reverted in #535. For consistency, we completely suppress the auto-removal of "empty" sections: removing the last setting of a section will not remove this section anymore, just like what happens for sections with only blank lines and comments.
In order to explicitly manage sections of an ini file regardless of
their content, we introduce a new ini_section type. This make it
possible to remove a whole section of an ini file, regardless of its
content:
```puppet
ini_section { 'remove puppet.conf agent section':
ensure => abent,
path => '/etc/puppetlabs/puppet/puppet.conf',
section => 'agent',
}
```
Just like the ini_setting type, ini_section can be subclassed:
```puppet
puppet_config { 'remove agent section':
ensure => abent,
section => 'agent',
}
```
Fixes #524
Ramesh7
force-pushed
the
524-add-ini_section
branch
from
fd331f1 to
f50f681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to explicitly manage sections of an ini file regardless of their content, we introduce a new
ini_sectiontype. This make it possible to remove a whole section of an ini file, regardless of its content:Just like the
ini_settingtype,ini_sectioncan be subclassed:Fixes #524