Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Heredoc rubocop and Disable Style/ClassAndModuleChildren where needed #510

Merged
merged 2 commits into from
May 10, 2023

Conversation

jstraw
Copy link
Contributor

@jstraw jstraw commented May 4, 2023

Disable the Style/ClassAndModuleChildren rubocop manually on the 4 places it is need until #509 is reviewed/resolved.

jstraw added 2 commits May 4, 2023 17:08
Disable the Style/ClassAndModuleChildren rubocop manually on the 4
places it is need until puppetlabs#509 is reviewed/resolved.
@jstraw jstraw requested a review from a team as a code owner May 4, 2023 22:14
@puppet-community-rangefinder
Copy link

ini_subsetting is a type

Breaking changes to this file MAY impact these 17 modules (near match):

This module is declared in 127 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for raising the issue.

@LukasAud
Copy link
Contributor

Waiting for CI to complete restart. There was a strange issue with one of the windows machines.

@LukasAud LukasAud merged commit 79e37cf into puppetlabs:main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants