Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add u32 to recognized modules #889

Conversation

mohammed-elhakim-sociomantic
Copy link
Contributor

@mohammed-elhakim-sociomantic mohammed-elhakim-sociomantic commented Jan 16, 2020

Similarly to https://tickets.puppetlabs.com/browse/MODULES-6379, we are getting warnings for u32:

Warning: Puppet::Type::Firewall::ProviderIptables: Skipping unparsable iptables rule: keys (5) and values (9) count mismatch on line: -A cali-fw-cali08818b3e1e0 -p udp -m comment --comment "cali:mpXsk9dUM2JyVL-L" -m comment --comment "Drop VXLAN encapped packets originating in pods" -m multiport --dports 4789 -m u32 --u32 "0x0>>0x16&0x3c@0xc>>0x8=0x1000" -j DROP

This fixes that

@mohammed-elhakim-sociomantic mohammed-elhakim-sociomantic requested a review from a team as a code owner January 16, 2020 12:46
@lionce
Copy link
Contributor

lionce commented Jan 20, 2020

Hey @mohammed-elhakim-sociomantic ,

Thank you for this fix. It looks good to me, but the new rule should be tested. Would be possible to add a test to cover this?

Cheers!

@sanfrancrisko
Copy link
Contributor

Thanks again for the submission @mohammed-elhakim-sociomantic . I've merged this as part of this PR: #917 as I didn't want to rebase master on your fork with active branches still being worked upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants