Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MODULES-10358) - Clarification added to Boolean validation checks #886

Merged
merged 1 commit into from
Jan 6, 2020
Merged

(MODULES-10358) - Clarification added to Boolean validation checks #886

merged 1 commit into from
Jan 6, 2020

Conversation

david22swan
Copy link
Member

No description provided.

@david22swan david22swan requested a review from a team as a code owner January 2, 2020 14:15
DavidS
DavidS suggested changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Looking for value( I've also found

    puppetlabs-firewall/lib/puppet/type/firewallchain.rb

    Line 241 in 5aaedbf

    rules_resources.delete_if { |res| value(:ignore).find_index { |f| res.provider.properties[:line].match(f) } } if value(:ignore)
    which seems to suffer the same issue.

  • doesn't value(:checksum_fill) and friends return :true/:false, instead of true/false? It'd be nice to have unit tests verifying this behaviour either way.

lib/puppet/type/firewall.rb Outdated
@@ -2303,7 +2303,7 @@ def should_to_s(value)
end
end

if value(:log_prefix) || value(:log_level) || value(:log_uid)
if value(:log_prefix) == true || value(:log_level) || value(:log_uid) == true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens/should happen when log_level is empty string? See

puppetlabs-firewall/lib/puppet/type/firewall.rb

Line 754 in 5aaedbf

if value.nil? && value != ''

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's handled inside the newproperty level

@david22swan david22swan force-pushed the MODULES-10358 branch 2 times, most recently from bf7cf1b to 3e424f7 Compare January 2, 2020 15:32
@DavidS DavidS merged commit aa6321d into puppetlabs:master Jan 6, 2020
@david22swan david22swan deleted the MODULES-10358 branch September 14, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidS DavidS DavidS approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david22swan @DavidS