Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Debian Unstable #876

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Add support for Debian Unstable #876

merged 1 commit into from
Nov 15, 2019

Conversation

martialblog
Copy link
Contributor

Replacement PR for #805

  • Added operatingsystemrelease unstable with netfilter service and package
  • Extended rspec tests for Debian

@martialblog martialblog requested a review from a team as a code owner November 15, 2019 09:51
 - Added operatingsystemrelease unstable with netfilter service and package
 - Extended rspec tests for Debian
@florindragos
Copy link
Contributor

Hey @martialblog,
Thank you for your contribution! 👍

@florindragos florindragos merged commit 9f73ac7 into puppetlabs:master Nov 15, 2019
@LiohMoeller
Copy link

The module has been flagged to support also Debian 10 and there are some additions to the spec tests for Buster as well. Actually the module calls iptables-save in the resource definition, which is a symlink to nftables in Debian 10+: https://wiki.debian.org/nftables

Even if the alternatives are configured accordingly afterwards, the module fails on first run with something like:

/Stage[main]/Itsystems_firewall::Config::Request/Resources[firewall] Failed to generate additional resources using 'generate': Execution of '/sbin/iptables-save' returned 1: iptables-save/1.8.2 Failed to initialize nft: Protocol not supported.

There has been some commits addressing the issue: 3614e5d which are mainly in the acceptance tests and not the actual module which also would need something like this in the resource definition before iptables-save:

if os[:family] == 'debian' && os[:release] == '10'
    run_shell('update-alternatives --set iptables /usr/sbin/iptables-legacy')
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants