(MODULES-10971) - Ensure apt::keyserver is considered when creating a default apt:source
#981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apt::params is a classthat may have no external impact to Forge modules. This module is declared in 234 of 576 indexed public
|
david22swan
force-pushed
the
MODULES-10971/main/aptkeyserver_fix
branch
from
4530429 to
18522b9
Compare
… a default apt:source As it stands the source_key_defaults point towards the default `keyserver` value set within the params. This change makes it so that it will instead use the `keyserver` value set in the init, which will in turn default to the params value in none has been given.
david22swan
force-pushed
the
MODULES-10971/main/aptkeyserver_fix
branch
from
18522b9 to
a6eb161
Compare
michaeltlombardi
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands the source_key_defaults point towards the default
keyservervalue set within the params. This change makes it so that it will instead use thekeyservervalue set in the init, which will in turn default to the params value if none has been given.