MODULES-10956 remove redundant code in provider apt_key #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in function `update_expired_key` is redundant to the logic in the function `create`. The call to function `exist` will mark the key as absent, in case it has expired and refres is set to true. I debugged for hours why my keys weren't updated until I realized, that the functionality is elsewhere.
Codecov Report
@@ Coverage Diff @@
## main #973 +/- ##
==========================================
+ Coverage 71.10% 72.72% +1.62%
==========================================
Files 5 5
Lines 263 253 -10
==========================================
- Hits 187 184 -3
+ Misses 76 69 -7
Continue to review full report at Codecov.
|
|
|
|
Closing and reopening PR, to see if the pr_test workflow is kicked off. |
|
I would like to thank you for taking the time and effort to create this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in function
update_expired_keyis redundant to the logic inthe function
create. The call to functionexistwill mark the key asabsent, in case it has expired and refres is set to true.
I debugged for hours why my keys weren't updated until I realized, that
the functionality is elsewhere.