Apt-key fixes to properly work on Debian 9

[ekohl]

On modern Debian(-based) distros this is needed for gpg to function when no TTY is available. Since Puppet often runs from cron or a daemon, this is often the case.

By using autorequire we can clean up the dirmngr handling around apt::key.

Verified by running:

PUPPET_INSTALL_TYPE=agent BEAKER_debug=true BEAKER_PUPPET_COLLECTION=puppet6 BEAKER_setfile='debian9-64{hypervisor=docker}' BEAKER_TESTMODE=apply bundle exec rspec spec/acceptance/apt_key_provider_spec.rb

[ekohl]

This may be needed now because of Debian 9.6 which did backport things to gnupg2.

[zeromind]

Corresponding Debian bug for gpg: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=913614

[ekohl]

Looks like they suggest to use --batch in any case.

[HelenCampbell]

Passed this through the adhoc pipeline and went green on Debian 9, as a result getting this merged in to address the issue. Thanks @ekohl for another solid fix!

[ekohl]

@HelenCampbell thanks for merging. I'd be great if there was a patch release so I don't have to apply workarounds in modules. Any plans around that?

[HelenCampbell]

@ekohl Yep there's a ticket in progress for releasing the module, you can track it here: https://tickets.puppetlabs.com/browse/MODULES-8226
It may be Monday before we get it out the door depending on how fast our pipelines run.

[ekohl]

Thanks! Watching the issue and I'll just get back to doing my own release then :)