MODULES-2873 - Avoid multiple package resource declarations #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you squash this down to a single commit please? Looks good otherwise. I'm not a big fan of |
werekraken
force-pushed
the
modules2873
branch
from
e31e97f to
08c8b58
Compare
|
Done. While I was in there I changed ensure_resource('package',...) to ensure_packages(). |
|
Perfect, thank you! This looks good to me. @bmjen According to (v|p)cci this thing passed so I'm going to merge. |
daenney
added a commit
that referenced
this pull request
Feb 2, 2016
MODULES-2873 - Avoid multiple package resource declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the change in #580 with tests to prevent reintroduction of the issue.