[WIP] Fixed apt::ppa path in Ubuntu Wily

[cristiklein]

No clue why, but the filenames that apt-add-repository produces seems to have changed in Wily. This update does the trick for me, but might not be backwards compatible.

[daenney]

Test tests tests.

[cristiklein]

This branch is not ready for merger yet, rather I wanted to discuss how to properly fix the issue. The filename for PPAs sources in /etc/apt/sources.list.d/ has changed in Ubuntu 15.10:

pre-wily: $team-$ppa-$release.list`    (e.g., `fish-shell-release-2-wily.list`)
wily    : $team-$distro-$ppa-$release` (e.g., `fish-shell-ubuntu-release-2-wily.list`)

I think the change was introduced here. This obviously confuses puppetlabs-apt, which triggers add-apt-repository and apt-get update unnecessarily.

Could you advise as to how properly fix this? Should I simply mirror the code in Ubuntu software-properties conditioning it on the release version? Or should I grep the whole /etc/apt/sources.list.d/? What mechanism would be more backwards compatible and more robust to future changes?

[daenney]

This branch is not ready for merger yet, rather I wanted to discuss how to properly fix the issue.

It would be helpful to mention that when you open a PR. As it stood all we got is a "here's a bug fix" that broke the associated tests. The WIP prefix only tells us so much.

Since the behaviour on Willy and forward includes the -distro- thing we should include that too to keep inline with the new behaviour and not confuse Puppet and the CLI tools. However, do note that you can't hardcode $distro to ubuntu as that will vary.

[imphil]

Btw, this addresses the same issue as #582.

[daenney]

Closed in favour of #582