apt::setting: Parse type and name from title. #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daenney
force-pushed
the
daenney/parse-setting-from-name
branch
from
ce4ed56 to
75487c1
Compare
| $setting_type = $title_array[0] | ||
| $base_name = join(delete_at($title_array, 0), '-') | ||
|
|
||
| validate_re($setting_type, ['^conf', '^pref', '^list'], "apt::setting resource name/title must start with either 'conf-', 'pref-' or 'list-'") |
There was a problem hiding this comment.
should these be ^conf$, ^pref$ and ^list$?
daenney
force-pushed
the
daenney/parse-setting-from-name
branch
from
75487c1 to
c67798c
Compare
| @@ -31,8 +31,6 @@ | |||
| } | |||
|
|
|||
| apt::setting { 'conf-update-stamp': | |||
| base_name => 'update-stamp', | |||
| setting_type => 'conf', | |||
| priority => 15, | |||
| content => template('apt/_header.erb', 'apt/15update-stamp.erb'), | |||
Instead of having two additional parameters, `base_name` and `setting_type` simply parse it from `title`. We need to prefix most resources with `list-`, `conf-`, or `pref-` any way to avoid duplicate resources so we might as well leverage that.
daenney
force-pushed
the
daenney/parse-setting-from-name
branch
from
c67798c to
d261d8f
Compare
underscorgan
pushed a commit
that referenced
this pull request
Feb 26, 2015
apt::setting: Parse type and name from title.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having two additional parameters,
base_nameandsetting_typesimply parse it fromtitle.We need to prefix most resources with
list-,conf-, orpref-any way to avoid duplicate resources so we might as well leverage that.