Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ports that consist of 5 decimals #400

Merged
merged 1 commit into from
Jan 8, 2015
Merged

Allow ports that consist of 5 decimals #400

merged 1 commit into from
Jan 8, 2015

Conversation

voidus
Copy link

@voidus voidus commented Dec 26, 2014

No description provided.

@daenney
Copy link

daenney commented Dec 30, 2014

Add a test for the new behaviour please.

@voidus
Copy link
Author

voidus commented Jan 3, 2015

I'm having problems running the beaker tests. This happens both with puppetlabs/master as well as voidus/master. Are the beaker tests currently functional? If yes, it would be great if you could take a look at the error I'm getting[1] and tell me if you see something.

I already tried to look into it myself, but I couldn't find anything in the puppetlabs-spec docu or through google.

[1] http://pastebin.com/UkngEuzn

@daenney
Copy link

daenney commented Jan 3, 2015

Right now I'm okay with ignoring the Beaker tests, at @mhaskel's discretion. I think we settled a while ago on not bugging the community about Beaker specs until we have a good way to run and visualise them for you without contributors needing to jump through fiery hoops of doom to get stuff running locally.

@underscorgan
Copy link

@voidus @daenney I'm ok just having unit tests for this feature.
To run the beaker-rspec tests we actually don't run them through rake, but they can be executed using bundle exec rspec spec/acceptance. More information can be found at https://github.com/puppetlabs/beaker/wiki/How-to-Write-a-Beaker-Test-for-a-Module

To get this ready for merge though can you rebase and squash it down to a single commit?

@voidus
Copy link
Author

voidus commented Jan 8, 2015

Done. Running the beaker tests through bundle exec rspec rspec/acceptance gives me the same error as rake beaker, though.

daenney added a commit that referenced this pull request Jan 8, 2015
Allow ports that consist of 5 decimals
@daenney daenney merged commit 65a5a25 into puppetlabs:master Jan 8, 2015
@daenney
Copy link

daenney commented Jan 8, 2015

Thank you! We'll see about sorting out the beaker stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants