apt::force: Added 2 parameters for automatic configuration file handling... #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing; fixes #modules-1306 when updating or installing newer packages with apt::force and you have changed previous configuration files aptitude or apt-get will prompt what to do. You can suppress that by pre-define the action with cfg_files parameter (new, old or unchanged and its backward compatible if not defined). With a second optional parameter cfg_missing you can force your provider to install missing configuration files as well. Signed-off-by: Martin Seener <[email protected]> apt::force: Changed selectors used in force.pp to case statements; refs #module-1306 Signed-off-by: Martin Seener <[email protected]> apt::force: rspec: fixed the failing tests and added validate_re for cfg_files and validate_bool for cfg_missing. Also removed default values for both case statements and only allow pre-defined values or true/false. Furthermore enhanced the README refs #module-1306 Was able to fix the failing rspec tests for the patch. Thanks to Morgan Haskel. Signed-off-by: Martin Seener <[email protected]> Despite the puppetlabs-stdlib documentation says validation_re supports 3 arguments the tests failed telling that only 2 are supported. Fixed this by removing the 3 optional argument; refs #modules-1306 Signed-off-by: Martin Seener <[email protected]> apt::force: updated readme refs #module-1306 Signed-off-by: Martin Seener <[email protected]>
|
@mhaskel ive squashed everything into one commit and rebased all this, recreated the branch and the PR. Voila! |
underscorgan
pushed a commit
that referenced
this pull request
Sep 24, 2014
…_if_new_package_asks_how_to_handle_changed_config_files apt::force: Added 2 parameters for automatic configuration file handling...
|
@martinseener thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...; fixes #modules-1306
when updating or installing newer packages with apt::force and you have changed previous
configuration files aptitude or apt-get will prompt what to do. You can suppress that
by pre-define the action with cfg_files parameter (new, old or unchanged and its backward
compatible if not defined). With a second optional parameter cfg_missing you can force
your provider to install missing configuration files as well.
Signed-off-by: Martin Seener [email protected]
apt::force: Changed selectors used in force.pp to case statements; refs #module-1306
Signed-off-by: Martin Seener [email protected]
apt::force: rspec: fixed the failing tests and added validate_re for cfg_files and validate_bool for cfg_missing. Also removed default values for both case statements and only allow pre-defined values or true/false. Furthermore enhanced the README refs #module-1306
Was able to fix the failing rspec tests for the patch.
Thanks to Morgan Haskel.
Signed-off-by: Martin Seener [email protected]
Despite the puppetlabs-stdlib documentation says validation_re supports 3 arguments the tests failed telling that only 2 are supported. Fixed this by removing the 3 optional argument; refs #modules-1306
Signed-off-by: Martin Seener [email protected]
apt::force: updated readme refs #module-1306
Signed-off-by: Martin Seener [email protected]