Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force owner and mode on ppa file creation #265

Closed
wants to merge 1 commit into from

Conversation

uu1101
Copy link

@uu1101 uu1101 commented Mar 9, 2014

Pull #227 set the owner and group when the file is ensure => absent. This change sets the owner, group and permissions when creating the file.

@daenney
Copy link

daenney commented Mar 9, 2014

The problem with this one is that the earlier Exec is actually responsible for creating the file with the right permission but since resource defaults are leaky you end up with this crap.

@uu1101 Before we consider this for merge, you need to update or create a test in at least spec/defines and since it's interacting with an exec a spec/acceptance test too to be sure we get the required state on the host. Also, you broke the tests.

@@ -60,6 +60,9 @@

file { "${sources_list_d}/${sources_list_d_filename}":
ensure => file,
mode => '0644',
owner => 'root',
gruop => 'root',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo.

@hunner
Copy link

hunner commented Mar 26, 2014

Given daenney's comment above, I'm going to close this for now. Feel free to update the branch and re-open the PR to address those issue!

@hunner hunner closed this Mar 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants