Handling of release parameter and apt provider in force manifest #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use release parameter to construct $release_string. The release parameter may also be set to false to use the system's default release (so just force a specific version). Use false as the default setting instead of 'testing'. Change $install_check to also check if package is installed from the right release, instead of just checking the version.
Use $apt::params::provider instead.
|
I think the backwards-incompatible change 1 is acceptible, and change 2 is the point of this PR, but I would like to see |
apenney
pushed a commit
that referenced
this pull request
Oct 15, 2013
Handling of release parameter and apt provider in force manifest
hunner
added a commit
to hunner/puppetlabs-apt
that referenced
this pull request
Feb 14, 2014
Undoes the parameter changes in puppetlabs#140 and puppetlabs#184
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #111
This PR contains two backwards-incompatible changes:
testingapt source and pinned the testing-origin packages to less than 500 and did not passrelease => 'testing'toapt::forcethen this will cause packages that are absent to be installed from the higher priority repo instead of thetestingrepo. This is low-impact and will not downgrade packages.apt::forceand have not been updated since newer releases were added to the release source then they will be automatically upgraded. This is medium-impact.