Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backports: pin using codename on Debian #1188

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

kenyon
Copy link

@kenyon kenyon commented Jun 10, 2024

Debian 11 bullseye and Debian 12 bookworm backports release files look like this:

https://deb.debian.org/debian/dists/bullseye-backports/InRelease:

Suite: bullseye-backports
Codename: bullseye-backports

https://deb.debian.org/debian/dists/bookworm-backports/InRelease:

Suite: stable-backports
Codename: bookworm-backports

Using "release" (aka Suite in the InRelease file) causes our pin to not match for bookworm because they changed it to stable-backports instead of $codename-backports. We can use codename to support both for this pin.

Fixes #1187.

We should drop Debian 10 support first: #1177.

@kenyon kenyon requested review from bastelfreak, smortex and a team as code owners June 10, 2024 20:18
@kenyon kenyon force-pushed the backports-pin-to-codename branch from 6913684 to 27c2361 Compare June 10, 2024 20:28
@kenyon kenyon changed the title backports: pin using codename backports: pin using codename on Debian Jun 10, 2024
@kenyon kenyon force-pushed the backports-pin-to-codename branch 2 times, most recently from 8f9d0af to 3279cf2 Compare June 15, 2024 18:12
smortex
smortex previously approved these changes Sep 13, 2024
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenyon kenyon mentioned this pull request Nov 21, 2024
3 tasks
Debian 11 bullseye and Debian 12 bookworm backports release files look
like this:

https://deb.debian.org/debian/dists/bullseye-backports/InRelease:

    Suite: bullseye-backports
    Codename: bullseye-backports

https://deb.debian.org/debian/dists/bookworm-backports/InRelease:

    Suite: stable-backports
    Codename: bookworm-backports

Using "release" (aka Suite in the InRelease file) causes our pin to not
match for bookworm because they changed it to stable-backports instead
of $codename-backports. We can use codename to support both for this
pin.

Fixes puppetlabs#1187.
Linux Mint is not listed as supported in the metadata.json file, so we
shouldn't carry tests for it (which are using facts for an end-of-life
release).
@kenyon kenyon force-pushed the backports-pin-to-codename branch from 59f7c75 to b717f97 Compare November 21, 2024 19:20
@amitkarsale amitkarsale merged commit b565ce0 into puppetlabs:main Nov 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apt::backports pins the wrong suite
6 participants