Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit empty options in source.list template to fix MODULES-11174 #1013

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

mpdude
Copy link

@mpdude mpdude commented Jan 9, 2022

Empty [name= ...] options in a soures list lead to Apt parsing errors.

This change skips such empty options, resolving https://tickets.puppetlabs.com/browse/MODULES-11174.

Empty `[name= ...]` options in a soures list lead to Apt parsing errors.

This change skips such empty options, resolving https://tickets.puppetlabs.com/browse/MODULES-11174.
@mpdude mpdude requested a review from a team as a code owner January 9, 2022 22:52
@CLAassistant
Copy link

CLAassistant commented Jan 9, 2022

CLA assistant check
All committers have signed the CLA.

@mpdude
Copy link
Author

mpdude commented Jan 9, 2022

Probably the issue was introduced in #991 and is because of a misbehaviour of delete_undef_values in Puppet 6.

As per https://tickets.puppetlabs.com/browse/MODULES-7835, this has been fixed in puppetlabs/stdlib 5.1.0, so upgrading to at least that version might also resolve the issue.

@LukasAud LukasAud merged commit 6cb996e into puppetlabs:main Feb 7, 2022
@LukasAud LukasAud added the bugfix label Feb 7, 2022
@mpdude mpdude deleted the patch-3 branch February 7, 2022 17:52
@mpdude mpdude restored the patch-3 branch February 7, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants