Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize the SecDebugLogLevel #2524

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Parametrize the SecDebugLogLevel #2524

wants to merge 2 commits into from

Conversation

zzacharo
Copy link

@zzacharo zzacharo commented Feb 8, 2024

Summary

At the moment the module hardcodes the mod_security debug level to 0 although it allows users to configure the debug log path. This PR introduces a new parameter called debug_log_level to be able to configure the SecDebugLogLevel.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@zzacharo zzacharo requested review from bastelfreak, ekohl, smortex and a team as code owners February 8, 2024 09:52
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@traylenator
Copy link
Contributor

Re the CLA CERN IT has an agreement with Puppetlabs that we have signed the CLA.

traylenator
traylenator suggested changes Feb 8, 2024
View reviewed changes
manifests/mod/security.pp Outdated Show resolved Hide resolved
spec/classes/mod/security_spec.rb Outdated Show resolved Hide resolved
spec/classes/mod/security_spec.rb Outdated Show resolved Hide resolved
@zzacharo zzacharo force-pushed the parametrize-debug-log-level branch from 5b2c37a to fc46598 Compare February 8, 2024 10:40
@zzacharo
Copy link
Author

@smortex any chance to integrate this soon-ish?

smortex
smortex approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ekohl
ekohl approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a more complete version of #2523. However, I can't merge it because of the CLA check.

@JGodin-C2C JGodin-C2C mentioned this pull request Apr 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@smortex smortex smortex approved these changes

@traylenator traylenator traylenator approved these changes

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

Assignees
No one assigned
Labels
community feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zzacharo @CLAassistant @traylenator @smortex @ekohl @ia-content