Support for mod_php on Ubuntu 22.04 #2278

xchotard-talentsoft · 2022-08-05T08:36:05Z

Summary

Changes

Added PHP version for Ubuntu 22.04 (and 16.04) to the $php_version mapping in params.pp.
In mod/php.pp added conditions for Red Hat family that has a specific behavior with PHP 8.x modules name convention.

Tests

Tested with the following Puppet code:

class { 'apache':
  mpm_module => 'prefork',
}
class { 'apache::mod::php': }

To validate that PHP works:

# Don't do this in production servers!
echo "<?php phpinfo(); ?>" > /var/www/html/phpinfo.php

Then open http://<sandbox_ip>/phpinfo.php

Works on:

Ubuntu 16.04
Ubuntu 18.04
Ubuntu 20.04
Ubuntu 22.04
CentOS 7
CentOS 8
Debian 11

I could not test SLES because it's not free. I tried openSuse Leap 15.4 but the module does not seems to work for other reasons.

CLAassistant · 2022-08-05T08:36:11Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

puppet-community-rangefinder · 2022-08-05T08:36:12Z

apache::mod::php is a class

Breaking changes to this file WILL impact these 49 modules (exact match):

Breaking changes to this file MAY impact these 36 modules (near match):

apache::params is a class

Breaking changes to this file WILL impact these 7 modules (exact match):

Breaking changes to this file MAY impact these 4 modules (near match):

This module is declared in 174 of 579 indexed public `Puppetfiles`.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

ekohl · 2022-08-05T09:03:53Z

Relevant previous effort: #2163

Tested with the following Puppet code:
class { 'apache':
  mpm_module => 'prefork',
}
class { 'apache::mod::php': }
To validate that PHP works:
# Don't do this in production servers!
echo "<?php phpinfo(); ?>" > /var/www/html/phpinfo.php
Then open http://<sandbox_ip>/phpinfo.php

This would be a great acceptance test. In fact, there already is https://github.com/puppetlabs/puppetlabs-apache/blob/main/spec/acceptance/mod_php_spec.rb but that doesn't run anything like curl to see if it actually renders.

david22swan · 2022-08-05T10:47:44Z

@xchotard-talentsoft If you could add Ubuntu 22.04 to the metadata that should activate the tests against it to double-check this change.
From my own pr added Certification for the OS it look's like yours should fix all outstanding issues.

xchotard-talentsoft · 2022-08-05T11:20:45Z

@xchotard-talentsoft If you could add Ubuntu 22.04 to the metadata that should activate the tests against it to double-check this change. From my own pr added Certification for the OS it look's like yours should fix all outstanding issues.

Done, but I haven't tested any of the other apache modules.

ekohl · 2022-08-05T13:04:41Z

manifests/params.pp

@@ -349,7 +349,9 @@
      $php_version = $facts['os']['release']['major'] ? {
        '9'     => '7.0', # Debian Stretch
        '10'    => '7.3', # Debian Buster
+        '16.04' => '7.0', # Ubuntu Xenial Xerus


Ubuntu 16.04 is EOL and unsupported. Please keep it out.

Do you mind if I remove this commit and do a force push ?

Not at all. In fact, that's what I do all the time.

ekohl · 2022-08-05T13:07:06Z

manifests/params.pp

        '20.04' => '7.4', # Ubuntu Foccal Fossal
+        '22.04' => '8.1', # Ubuntu Jellyfish


I'd imagine 22.04 is closer to Debian Bullseye. It's mostly about the mod_packages list. So I'd suggest to change line 348 with a versioncmp. Possibly Ubuntu 20.04 is also more like Debian Bullseye than this list.

I admit I don't know exactly what the versioncmp() does here. I would use the following block code instead (from L348 to L355:

if ($facts['os']['family'] == 'Debian') { $php_version = $facts['os']['release']['major'] ? { '9' => '7.0', # Debian Stretch '10' => '7.3', # Debian Buster '11' => '7.4', # Debian Bullseye '18.04' => '7.2', # Ubuntu Bionic '20.04' => '7.4', # Ubuntu Focal '22.04' => '8.1', # Ubuntu Jammy default => '7.4', # Debian Bullseye, Ubuntu Focal } ...

I agree the $php_version part should be pulled out of the versioncmp and I swear I considered the exact same thing but failed to write it down. However, the list of modules can use a versioncmp. It's still not entirely correct, like #2281 should clean things up further.

david22swan · 2022-08-17T15:44:54Z

@xchotard-talentsoft
Hey, as part of my scheduled work to get all our our modules to support Ubuntu 22.04 have finalized the work started by you and added it to the pdksync PR shown here and was hoping you could give it a quick review.

Hope there's no offense taken, just need to get this done so I can move onto my next task.
Pinging @ekohl as well

david22swan · 2022-09-05T10:07:23Z

@xchotard-talentsoft Closing this as the need has bee filled by another PR.
If there is anything else that you wanted to get in with it please re-open and comment.

Thank you for all your work

xchotard-talentsoft added 3 commits August 5, 2022 10:03

Ubuntu 22.04 php version

09d0255

Ubuntu 16.04 php version

2cb831a

php8 module names for redhat

73299fc

xchotard-talentsoft requested a review from a team as a code owner August 5, 2022 08:36

ia-content added the community label Aug 5, 2022

david22swan added bugfix feature and removed bugfix labels Aug 5, 2022

added ubuntu 22.04

9180b76

ekohl reviewed Aug 5, 2022

View reviewed changes

david22swan closed this Sep 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for mod_php on Ubuntu 22.04 #2278

Support for mod_php on Ubuntu 22.04 #2278

xchotard-talentsoft commented Aug 5, 2022

CLAassistant commented Aug 5, 2022

puppet-community-rangefinder bot commented Aug 5, 2022

ekohl commented Aug 5, 2022

david22swan commented Aug 5, 2022

xchotard-talentsoft commented Aug 5, 2022

ekohl Aug 5, 2022

xchotard-talentsoft Aug 11, 2022

ekohl Aug 11, 2022

ekohl Aug 5, 2022

xchotard-talentsoft Aug 11, 2022 •

edited

Loading

ekohl Aug 11, 2022

david22swan commented Aug 17, 2022 •

edited

Loading

david22swan commented Sep 5, 2022

		'20.04' => '7.4', # Ubuntu Foccal Fossal
		'22.04' => '8.1', # Ubuntu Jellyfish

Support for mod_php on Ubuntu 22.04 #2278

Support for mod_php on Ubuntu 22.04 #2278

Conversation

xchotard-talentsoft commented Aug 5, 2022

Summary

Changes

Tests

CLAassistant commented Aug 5, 2022

puppet-community-rangefinder bot commented Aug 5, 2022

apache::mod::php is a class

apache::params is a class

This module is declared in 174 of 579 indexed public Puppetfiles.

ekohl commented Aug 5, 2022

david22swan commented Aug 5, 2022

xchotard-talentsoft commented Aug 5, 2022

ekohl Aug 5, 2022

Choose a reason for hiding this comment

xchotard-talentsoft Aug 11, 2022

Choose a reason for hiding this comment

ekohl Aug 11, 2022

Choose a reason for hiding this comment

ekohl Aug 5, 2022

Choose a reason for hiding this comment

xchotard-talentsoft Aug 11, 2022 • edited Loading

Choose a reason for hiding this comment

ekohl Aug 11, 2022

Choose a reason for hiding this comment

david22swan commented Aug 17, 2022 • edited Loading

david22swan commented Sep 5, 2022

This module is declared in 174 of 579 indexed public `Puppetfiles`.

xchotard-talentsoft Aug 11, 2022 •

edited

Loading

david22swan commented Aug 17, 2022 •

edited

Loading