Disable mod_php on EL9 #2277
Merged
Disable mod_php on EL9 #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
disable-mod-php-on-el9
branch
2 times, most recently
from
d358efa to
0cc48f5
Compare
david22swan
requested changes
Aug 5, 2022
manifests/mod/php.pp
Outdated
| @@ -34,7 +35,7 @@ | |||
| String $template = 'apache/mod/php.conf.erb', | |||
| Optional[String] $source = undef, | |||
| Optional[String] $root_group = $apache::params::root_group, | |||
| Optional[String] $php_version = $apache::params::php_version, | |||
| String[1] $php_version = $apache::params::php_version, | |||
There was a problem hiding this comment.
Rather than this would it not be better to put a check in to detect when its running on RHEL 9 and fail with a message stating that php-fpm should be used instead?
i.e.:
if $facts['os']['name'] == 'Redhat' and $facts['os']['release']['major'] == '9' {
fail("RHEL 9 does not support 'mod_php' and so 'php-fpm' must be used instead.")
}
There was a problem hiding this comment.
Make the reasoning and cause explicit?
There was a problem hiding this comment.
How about this solution: keeping it Optional, but treat undef as unsupported?
ekohl
force-pushed
the
disable-mod-php-on-el9
branch
from
0cc48f5 to
330bcd5
Compare
david22swan
approved these changes
Aug 5, 2022
david22swan
requested changes
Aug 8, 2022
ekohl
force-pushed
the
disable-mod-php-on-el9
branch
from
330bcd5 to
1177959
Compare
Unit tests run on all supported OSes (according to metadata.json) |
bastelfreak
previously approved these changes
Aug 8, 2022
ekohl
force-pushed
the
disable-mod-php-on-el9
branch
from
1177959 to
3fcaec7
Compare
|
Ah right, the unsupported comment works on the acceptance test |
EL 9 doesn't ship mod_php, so this is uninstallable. By making it a required parameter (which effectively was already the case) and setting the version to undef the catalog fails to compile by default. This still allows users to set it if they build a mod_php somehow. EL 9 users should use php-fpm instead. Fixes: edbdb65
ekohl
force-pushed
the
disable-mod-php-on-el9
branch
from
3fcaec7 to
51bc232
Compare
|
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EL 9 doesn't ship mod_php, so this is uninstallable. By making it a required parameter (which effectively was already the case) and setting the version to undef the catalog fails to compile by default. This still allows users to set it if they build a mod_php somehow.
EL 9 users should use php-fpm instead.
A draft right now to see which tests fail.
Fixes: edbdb65