Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding CRS allowed HTTP methods per vhost #2274

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Allow overriding CRS allowed HTTP methods per vhost #2274

merged 2 commits into from
Aug 5, 2022

Conversation

Vincevrp
Copy link
Contributor

No description provided.

@Vincevrp Vincevrp requested a review from a team as a code owner July 29, 2022 14:50
@puppet-community-rangefinder
Copy link

apache::vhost is a type

Breaking changes to this file WILL impact these 128 modules (exact match):
Breaking changes to this file MAY impact these 36 modules (near match):

This module is declared in 174 of 579 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@Vincevrp Vincevrp force-pushed the vhost-allowed-methods branch 2 times, most recently from 4aedec1 to 774bb7a Compare August 1, 2022 21:22
@Vincevrp Vincevrp force-pushed the vhost-allowed-methods branch from 774bb7a to 54d08fa Compare August 4, 2022 20:52
@Vincevrp
Copy link
Contributor Author

Vincevrp commented Aug 4, 2022

@david22swan Rebased. Should be good to go now.

david22swan
david22swan reviewed Aug 5, 2022
View reviewed changes
manifests/vhost.pp
@@ -1913,6 +1916,7 @@
Optional[String] $modsec_body_limit = undef,
Optional[Integer[1, default]] $modsec_inbound_anomaly_threshold = undef,
Optional[Integer[1, default]] $modsec_outbound_anomaly_threshold = undef,
Optional[String] $modsec_allowed_methods = undef,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vincevrp
Could you give me your reasoning on why this is a String and not and Array?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david22swan To be consistent with https://github.com/puppetlabs/puppetlabs-apache/blob/main/manifests/mod/security.pp#L124

david22swan
david22swan approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that clarification on the type...

LGTM
Thank's for all the work you've put in his week :)

@david22swan david22swan merged commit c467cf4 into puppetlabs:main Aug 5, 2022
@david22swan
Copy link
Member

Plan is for a release to go out today so you should have your changes availible pretty quick

@Vincevrp
Copy link
Contributor Author

Vincevrp commented Aug 5, 2022

@david22swan Thanks for the quick feedback and merges. More contributions to come :)

@Vincevrp Vincevrp deleted the vhost-allowed-methods branch August 5, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

Assignees
No one assigned
Labels
community feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vincevrp @david22swan @ia-content