Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop suphp support #2263

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Drop suphp support #2263

merged 1 commit into from
Jul 25, 2022

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Jul 20, 2022

suphp was discontinued in 2013. At this point nobody should use it anymore.

@ekohl
Drop suphp support
35800a2 
suphp was discontinued in 2013. At this point nobody should use it
anymore.
@ekohl ekohl requested a review from a team as a code owner July 20, 2022 13:33
@ekohl
Copy link
Collaborator Author

ekohl commented Jul 20, 2022

I have not updated the Japanese README since I'm not sure what I'd be doing.

david22swan
david22swan approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Have talked with the team and this is good for us.
Looking at the spec test's the failures seem to be present on master so gonna go ahead and merge.

🥳

@david22swan david22swan merged commit 1393439 into puppetlabs:main Jul 25, 2022
@ekohl ekohl deleted the drop-suphp branch July 25, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
backwards-incompatible community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekohl @bastelfreak @david22swan @ia-content