Only warn about servername logging if relevant #2154
Conversation
|
@ekohl You seem to have a lot of test failures here, have you had a chance to look at them more closely? |
The warning about $use_servername_for_filenames is long and may not affect users. If they use a normal $name, there would effectively be no difference. This compares $name to $normalized_servername. The warning is only relevant Only if they differ. Technically there could be a space in $servername (since there is no data type to enforce validation) but Apache wouldn't accept that anyway. It also fixes two typos in the warnings.
|
I think when I pushed this I was unable to run Puppet locally since the ecosystem was Ruby 3 incompatible. Right now rodjek/rspec-puppet#830 still makes it harder than it needs to be. Also that there's no Looks like I had a syntax error which caused the whole tests to fail for obvious reasons. What we do in Voxpupuli is a single test job that runs basic validations prior to running any other tests. It also determines the matrix. That saves a lot of CI resources on these trivial mistakes. |
|
@ekohl Sorry for the trouble, but thank you for the work. This is the nice sort of change that only someone who actually work's with the module would think of, gonna go ahead and merge it. Once again, thank you for putting in the effort :) |
|
Hmm, I've just updated to 6.3.0, but I still see that warning although none of my vhosts have whitespace in their names. |
The warning about $use_servername_for_filenames is long and may not affect users. If they use a normal $name, there would effectively be no difference. This compares $name to $normalized_servername. The warning is only relevant Only if they differ.
Technically there could be a space in $servername (since there is no data type to enforce validation) but Apache wouldn't accept that anyway.
It also fixes two typos in the warnings.
Please make sure my logic is correct here, I'm not 100% sure it is.