(MODULES-11061) mod_security custom rule functionality

[k2patel]

Basic Info
Module Version: 6.0.0
Puppet Version: 6.21.1
OS Name/Version: RHEL

Apache module activates the mod_security, but there is no way to manage custom rules.

For example, to override rules or create rules, etc.

Desired Behavior:

Allow adding custom rules to the security configuration.

Actual Behavior:

Functionality does not exist.

[puppet-community-rangefinder]

apache::mod::security is a class

that may have no external impact to Forge modules.

apache::params is a class

Breaking changes to this file WILL impact these 16 modules (exact match):

• xdrum-puppet
• brucem-ezpublish
• desalvo-bacula
• jlondon-phpmyadmin
• osc-openondemand
• openstack-keystone
• openstack-barbican
• openstack-manila
• openstack-cinder
• openstack-panko
• openstack-zaqar
• openstack-aodh
• openstack-ironic
• openstack-neutron
• openstack-mistral
• openstack-octavia

Breaking changes to this file MAY impact these 11 modules (near match):

• ULHPC-passenger
• camptocamp-catalog_diff
• openstack-cloudkitty
• openstack-vitrage
• openstack-magnum
• openstack-watcher
• openstack-gnocchi
• openstack-sahara
• willdurand-bazinga
• openstack-tripleo
• openstack-heat

This module is declared in 175 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[k2patel]

Failed checks are not related to the merge.

[david22swan]

@k2patel This change looks good but to go in I'd like it to have some positive test cases, not just the negative ones that you have included.
Once that's done I would be happy to merge.

[k2patel]

@k2patel This change looks good but to go in I'd like it to have some positive test cases, not just the negative ones that you have included.
Once that's done I would be happy to merge.

@david22swan This should be done, let me know if that works.

[k2patel]

@david22swan is there any time frame when it would be merged?

[david22swan]

LGTM

[pmcmaw]

Test updates LGTM. :-)

[david22swan]

@k2patel Thanks for putting in the work and getting responding to my comments in such a speedy manner.
With your changes in I am now happy to merge!

Thank you again for putting in the effort.