Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mod_auth_gssapi parameters #2078

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Conversation

traylenator
Copy link
Contributor

@traylenator traylenator commented Oct 23, 2020

mod_auth_gssapi parameters can only used inside a directory section of a vhost.

Parameters are specified as a hash gssapi to the directories parameter.

Currently only the three obvious parameters are supported, adding extra ones is a
trivial addition to the _gssapi.epp template.

Example

include apache::mod::auth_gssapi
apache::vhost { 'sample.example.net':
  docroot     => '/path/to/directory',
  directories => [
    { path   => '/path/to/different/dir',
      gssapi => {
        credstore => 'keytab:/foo/bar.keytab',
        localname => 'Off',
        sslonly   => 'On',
      }
    },
  ],

These 3 values match to an apache configuration of

<Directory /path/to/different/directory>
  GssapiSSLonly Off
  GssapiLocalName On
  GssapiCredStore keytab:/foo/bar.keytab
</Directory>

https://github.com/gssapi/mod_auth_gssapi#gssapisslonly

mod_auth_gssapi parameters can only used inside a directory section of a vhost.

Parameters are specified as a hash `gssapi` to the directories parameter.

Currently only the three obvious parameters are supported, adding extra ones is a
trivial addition to the `_gssapi.epp` template.

Example

```puppet
include apache::mod::auth_gssapi
apache::vhost { 'sample.example.net':
  docroot     => '/path/to/directory',
  directories => [
    { path   => '/path/to/different/dir',
      gssapi => {
        credstore => 'keytab:/foo/bar.keytab',
        localname => 'Off',
        sslonly   => 'On',
      }
    },
  ],
```

These 3 values match to an apache configuration of

```config
<Directory /path/to/directory>
  GssapiSSLonly Off
  GssapiLocalName On
  GssapiCredStore keytab:/foo/bar.keytab
</Directory>
```

https://github.com/gssapi/mod_auth_gssapi#gssapisslonly
@traylenator traylenator requested a review from a team as a code owner October 23, 2020 14:25
@puppet-community-rangefinder
Copy link

apache::vhost is a type

Breaking changes to this file WILL impact these 125 modules (exact match):
Breaking changes to this file MAY impact these 32 modules (near match):

This module is declared in 174 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@adrianiurca
Copy link
Contributor

Hi @traylenator, thank you for your contribution!

@adrianiurca adrianiurca merged commit aae3668 into puppetlabs:main Oct 26, 2020
@traylenator
Copy link
Contributor Author

Thanks a lot for the merge but it was not really ready, hence the WIP: tag.
I have now tested in real life and all good.
Thanks.

@traylenator
Copy link
Contributor Author

In the future I'll use the draft mechanism.

@traylenator traylenator changed the title WIP: Support mod_auth_gssapi parameters Support mod_auth_gssapi parameters Oct 27, 2020
@pmcmaw pmcmaw added the feature label Nov 25, 2020
@traylenator traylenator deleted the gssapi branch July 6, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants