Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ruby 2.7 compatible string matching #2074

Merged

Conversation

sanfrancrisko
Copy link
Contributor

@sanfrancrisko sanfrancrisko commented Oct 6, 2020

#2060 was incorrectly merged to master instead of main:

In Ruby 2.7, performing true =~ %r{false}i raises a deprecation warning.

Use Ruby 2.7 compatible string matching
@sanfrancrisko sanfrancrisko requested a review from a team as a code owner October 6, 2020 13:24
@puppet-community-rangefinder
Copy link

apache::bool2httpd is a function

that may have no external impact to Forge modules.

This module is declared in 174 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@sanfrancrisko sanfrancrisko changed the title Merge pull request #2060 from ekohl/ruby-2.7 Use Ruby 2.7 compatible string matching Oct 6, 2020
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@bd84127). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2074   +/-   ##
=======================================
  Coverage        ?   57.40%           
=======================================
  Files           ?       12           
  Lines           ?      216           
  Branches        ?        0           
=======================================
  Hits            ?      124           
  Misses          ?       92           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd84127...7731b8c. Read the comment docs.

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed the default branch was switched and doesn't include this anymore, leading to deprecation warnings again.

@david22swan david22swan merged commit 3877dd9 into puppetlabs:main Oct 12, 2020
@sanfrancrisko sanfrancrisko deleted the fix/pr-2060-incorrect-branch branch November 24, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants