Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make apache::mod::fcgid redhat 8 compatible #2071

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

creativefre
Copy link
Contributor

before -> rhel 8, fcgid.load is loaded before unixd.load  which causes httpd to fail
So the name unixd_fcgid.load should also be implemented for rhel 8

before -> rhel 8 fcgid.load is loaded before unixd.load  which causes httpd to fail
@creativefre creativefre requested a review from a team as a code owner September 30, 2020 13:14
@puppet-community-rangefinder
Copy link

apache::mod::fcgid is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

This module is declared in 174 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@c610f78). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2071   +/-   ##
=======================================
  Coverage        ?   58.49%           
=======================================
  Files           ?       12           
  Lines           ?      212           
  Branches        ?        0           
=======================================
  Hits            ?      124           
  Misses          ?       88           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c610f78...a0f685d. Read the comment docs.

@adrianiurca
Copy link
Contributor

Hi @creativefre, thank you for your contribution.

@adrianiurca adrianiurca merged commit bcefcbb into puppetlabs:main Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants