MODULES-10586 Centos 8: wrong package used to install mod_authnz_ldap

[farebers]

see https://tickets.puppetlabs.com/browse/MODULES-10586

the change was tested on a fresh centos 8 install

note on unit tests:

• I edited the tests 'default configuration with parameters on a RedHat OS' in authnz_ldap_spec.rb and ldap_spec.rb (updated the facts operatingsystemrelease line to '8') in the puppetlabs module (not containing my change)
• so those tests should have failed but didn't

so I was unable to provide a sensible unit test

[sanfrancrisko]

Hi @farebers,

Firstly, thank you for the fix and highlighting the gap in the test coverage to capture this. As you pointed out, the unit tests did not catch this failure. We can certainly extend spec/classes/mod/authnz_ldap_spec.rb to verify that we are using the correct package name on RHEL systems based on their major versions, but, unfortunately this will not catch the failure until the manifest is actually compiled on an OS.

I think the best thing is to to add an acceptance test for this particular scenario in a file called spec/acceptance/mod_authnz_ldap_spec.rb, something along the lines of this:

require 'spec_helper_acceptance'
apache_hash = apache_settings_hash

describe 'apache::mod_authnz_ldap' do
  context 'Default mod_authnz_ldap module installation' do
    pp = <<-MANIFEST
      class { 'apache': }
      class { 'apache::mod::auth::authnz_ldap': }
    MANIFEST

    it 'succeeds in installing the mod_authnz_ldap module' do
      apply_manifest(pp, catch_failures: true)

      describe file("#{apache_hash['mod_dir']}/authnz_ldap.load") do
        it { is_expected.to contain 'mod_authnz_ldap.so' }
      end
    end
  end
end

This will ensure that the installation of the package works correctly.

I have been taking a look at how we could enhance the unit tests, doing something like this:

on_supported_os.each do |os, facts|
      context "On #{os}" do
        let :facts do
          facts
        end

        it { is_expected.to contain_class('apache::params') }
        it { is_expected.to contain_class('apache::mod::ldap') }
        it { is_expected.to contain_apache__mod('authnz_ldap') }

        if facts[:os]['name'] == 'Redhat' and facts[:os]['version'].to_i < 7
          it { is_expected.to contain_package('mod_authz_ldap') }
        elsif facts[:os]['name'] == 'Redhat' and facts[:os]['version'].to_i > 6
          it { is_expected.to contain_package('mod_ldap')}
        end

...but there's a few issues I'm running in to with this approach.

I think the path of least resistance would be to add an acceptance test, similar to above. Let me know if I can be of any further help.