Add template variables and parameters for ModSecurity Audit Logs #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jplindquist
commented
Dec 31, 2019
•
jplindquist
commented
- Add new parameter and update security.conf template to enable configuration of ModSecurity SecAuditLogType
- Add new parameter and update security.conf template to enable configuration of ModSecurity SecAuditLogStorageDir
- Add tests for new parameters and defaults
jplindquist
changed the title
jplindquist
force-pushed
the
modsec-audit-log
branch
from
5264e8c to
573bc5d
Compare
jplindquist
force-pushed
the
modsec-audit-log
branch
from
573bc5d to
79407f7
Compare
|
Thanks @jplindquist for submitting the PR. Could you please fix the Travis failures. Thank you. |
|
Thanks @sheenaajay for looking at this. Is there a way to rerun those, or the one that failed? I don't see how those error(s) could be related to the changes I introduced. I'm not really sure on how to go about debugging that yet |
|
@jplindquist Rerunning the job now.Thank you. |
|
@sheenaajay Looks like everything passed, do you need anything else as part of this before it gets merged? |
michaeltlombardi
approved these changes
Jan 23, 2020
cegeka-jenkins
pushed a commit
to cegeka/puppet-apache
that referenced
this pull request
Jul 15, 2020
Add template variables and parameters for ModSecurity Audit Logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.