-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(MODULES-10432) Add mod_auth_openidc support #1987
Conversation
@asieraguado create a ticket in https://tickets.puppetlabs.com/projects/MODULES and link to this. Generally this seems good to me. |
Ticket created. |
Thank you @asieraguado for your contribution. The changes and unit test cases look good. It will be great if you can add some acceptance test to verify the changes. |
Thank you @sheenaajay for your review. I included an acceptance test in [1] https://packages.ubuntu.com/xenial/web/libapache2-mod-auth-openidc |
@sheenaajay ubuntu 14.04 is EOL. Can it be removed as a test target? |
Thanks, we're eagerly waiting for this fix to be merged. 👍 |
For now you can skip that os in the acceptance test. I'd also like to see this merged :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @asieraguado, thanks for your contribution!
I think the skip is perfectly fine so long as the reason it fails on 14.04 is because it's not implemented.
Co-Authored-By: Michael T Lombardi (He/Him) <[email protected]>
Thank you, applied the change to skip Ubuntu 14.04 in the test. |
Co-Authored-By: Michael T Lombardi (He/Him) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, time to merge!
(MODULES-10432) Add mod_auth_openidc support
Adds mod_auth_openidc and the parameters
auth_oidc
,oidc_settings
to enable OpenID Connect authentication and authorization for avhost
.