Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10432) Add mod_auth_openidc support #1987

Merged
merged 4 commits into from
Feb 3, 2020

Conversation

asieraguado
Copy link
Contributor

Adds mod_auth_openidc and the parameters auth_oidc, oidc_settings to enable OpenID Connect authentication and authorization for a vhost.

@traylenator
Copy link
Contributor

@asieraguado create a ticket in https://tickets.puppetlabs.com/projects/MODULES and link to this.

Generally this seems good to me.

@asieraguado
Copy link
Contributor Author

@asieraguado asieraguado changed the title Add mod_auth_openidc to the supported modules (MODULES-10432) Add mod_auth_openidc to the supported modules Jan 14, 2020
@sheenaajay
Copy link
Contributor

Thank you @asieraguado for your contribution. The changes and unit test cases look good. It will be great if you can add some acceptance test to verify the changes.

@asieraguado
Copy link
Contributor Author

Thank you @sheenaajay for your review. I included an acceptance test in vhost_spec.rb that verifies auth_oidc and its settings. There is one CI test failing for Ubuntu 14.04, but the same test should pass for Ubuntu 16.04 - the required package is available at least since this version [1].

[1] https://packages.ubuntu.com/xenial/web/libapache2-mod-auth-openidc

@traylenator
Copy link
Contributor

@sheenaajay ubuntu 14.04 is EOL. Can it be removed as a test target?

@nilsjh
Copy link

nilsjh commented Jan 29, 2020

Thanks, we're eagerly waiting for this fix to be merged. 👍

@ekohl
Copy link
Collaborator

ekohl commented Jan 29, 2020

For now you can skip that os in the acceptance test. I'd also like to see this merged :)

Copy link
Contributor

@michaeltlombardi michaeltlombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @asieraguado, thanks for your contribution!

I think the skip is perfectly fine so long as the reason it fails on 14.04 is because it's not implemented.

spec/acceptance/vhost_spec.rb Outdated Show resolved Hide resolved
@michaeltlombardi michaeltlombardi changed the title (MODULES-10432) Add mod_auth_openidc to the supported modules (MODULES-10432) Add mod_auth_openidc support Jan 30, 2020
Co-Authored-By: Michael T Lombardi (He/Him) <[email protected]>
@asieraguado
Copy link
Contributor Author

Thank you, applied the change to skip Ubuntu 14.04 in the test.

spec/acceptance/vhost_spec.rb Outdated Show resolved Hide resolved
Co-Authored-By: Michael T Lombardi (He/Him) <[email protected]>
Copy link
Contributor

@michaeltlombardi michaeltlombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, time to merge!

@michaeltlombardi michaeltlombardi merged commit e85046d into puppetlabs:master Feb 3, 2020
cegeka-jenkins pushed a commit to cegeka/puppet-apache that referenced this pull request Jul 15, 2020
(MODULES-10432) Add mod_auth_openidc support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants