Fix newline being added before proxy params #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a proxy_pass with additional params is defined within a location block, the params were appended in a new line.
|
The failed tests seem unrelated to my changes. |
|
Thanks @oxc for submitting the PR. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-apache
that referenced
this pull request
Jul 15, 2020
Fix newline being added before proxy params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a proxy_pass with additional params is defined within a directories location entry, the params get appended in a new line (which breaks config).
The change in this pull request removes the superfluous newline.