Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-9668 ) Please make ProxyRequests setting in vhost.pp configurable #1935

Merged
merged 12 commits into from
Aug 20, 2019

Conversation

aukesj
Copy link

@aukesj aukesj commented Aug 5, 2019

This fork and change makes 'ProxyRequests' in Apache vhost sections managed by puppetlabs-apache configurable. I created a Jira ticket as well (MODULES-9668)

manifests/vhost.pp Outdated Show resolved Hide resolved
REFERENCE.md Show resolved Hide resolved
@ThoughtCrhyme ThoughtCrhyme changed the title Please make ProxyRequests setting in vhost.pp configurable (MODULES-9668 ) Please make ProxyRequests setting in vhost.pp configurable Aug 12, 2019
Copy link
Contributor

@ThoughtCrhyme ThoughtCrhyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR and filing of a bug against this module. Please address @ekohl and my feedback. Also I see a test for the default value set to false if we can test the true code path as well we can get this merged. Thanks again.

REFERENCE.md Outdated Show resolved Hide resolved
ThoughtCrhyme
ThoughtCrhyme previously approved these changes Aug 14, 2019
@ThoughtCrhyme ThoughtCrhyme dismissed their stale review August 14, 2019 21:23

Premature approval. Still needs test for proxy set to true.

@aukesj
Copy link
Author

aukesj commented Aug 15, 2019

I ran the tests up to 'bundle exec rspec spec/acceptance' (which fails locally with these errors (12 times):

An error occurred while loading ./spec/acceptance/vhosts_spec.rb. Failure/Error: require 'beaker-rspec/spec_helper' RuntimeError: Failed to exec 'vagrant destroy --force'. Error was /usr/lib/ruby/2.5.0/rubygems.rb:289:in find_spec_for_exe': can't find gem vagrant (>= 0.a) with executable vagrant (Gem::GemNotFoundException)
from /usr/lib/ruby/2.5.0/rubygems.rb:308:in activate_bin_path' from /usr/local/bin/vagrant:23:in

'`

The Unit tests succeeded however (bundle exec rake spec):

Finished in 44 minutes 44 seconds (files took 3 minutes 8 seconds to load) 7439 examples, 0 failures

@aukesj
Copy link
Author

aukesj commented Aug 15, 2019

Furthermore, I'm using the fork succesfully with the option proxy_requests enabled.

REFERENCE.md Outdated Show resolved Hide resolved
@ThoughtCrhyme ThoughtCrhyme merged commit 401a037 into puppetlabs:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants