-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(MODULES-9668 ) Please make ProxyRequests setting in vhost.pp configurable #1935
Conversation
…ault is Off. By setting proxy_requests to 'true' it will become 'ProxyRequests On'
…TORY.md and REFERENCE.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR and filing of a bug against this module. Please address @ekohl and my feedback. Also I see a test for the default value set to false
if we can test the true
code path as well we can get this merged. Thanks again.
Premature approval. Still needs test for proxy set to true.
I ran the tests up to 'bundle exec rspec spec/acceptance' (which fails locally with these errors (12 times):
The Unit tests succeeded however (
|
Furthermore, I'm using the fork succesfully with the option proxy_requests enabled. |
This fork and change makes 'ProxyRequests' in Apache vhost sections managed by puppetlabs-apache configurable. I created a Jira ticket as well (MODULES-9668)