Fix wsgi_daemon_process to support hash data type #1884
Conversation
|
Hello @mdechiaro , Thank you for your contribution. It looks like this branch has some conflicts. In order to merge this PR, please resolve them :) |
The README states wsgi_daemon_process is a hash data type however the ERB template interpolates it as a string. As this type it currently cannot accept multiple daemon processes per vhost, and requires wsgi_daemon_process_options to manage parameters. This commit adds logic to the parameter to support this data type while maintaining original functionality. The data type allows for multiple daemons per vhost, and deprecates wsgi_daemon_process_options.
|
@lionce I fixed the conflicts. |
|
Hello @mdechiaro , Looks good to me! Thanks for this PR. Cheers! |
…_hash_fix Fix wsgi_daemon_process to support hash data type
Fix depreciation introduced by puppetlabs/puppetlabs-apache#1884
|
I appreciate the move to support Hash options for WSGI, but no one modified the documentation to give guidance as to how to implment this hash. Unfortunately, puppet fails with a message: "This parameter is deprecated. Please add values inside Hash with language pre-dating this change even though the author tried to maintain the original behavior. Can we get an update to what a configuration should look like? |
The README states wsgi_daemon_process is a hash data type however the
ERB template interpolates it as a string. As this type it currently
cannot accept multiple daemon processes per vhost, and requires
wsgi_daemon_process_options to manage parameters.
This commit adds logic to the parameter to support this data type while
maintaining original functionality. The data type allows for multiple
daemons per vhost, and deprecates wsgi_daemon_process_options.