(IAC-825) - Adding net-ssh 5 dependent gems

[pmcmaw]

Placing net-ssh 5 dependent gems into the gemspec. This means they are added in 1 place rather than in all modules.

[pmcmaw]

This change has been tested by making motd point at these changes and they have passed:
https://github.com/puppetlabs/puppetlabs-motd/runs/709501022?check_suite_focus=true

[codecov-commenter]

Codecov Report

Merging #297 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #297   +/-   ##
=======================================
  Coverage   62.87%   62.87%           
=======================================
  Files           7        7           
  Lines         765      765           
=======================================
  Hits          481      481           
  Misses        284      284           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e54cc1b...8aa2287. Read the comment docs.

[pmcmaw]

These changes have been tested on motd and are passing on github actions.
https://github.com/puppetlabs/puppetlabs-motd/runs/713400234?check_suite_focus=true

[pmcmaw]

This has been tested on puppet_conf and passed: https://github.com/puppetlabs/puppetlabs-puppet_conf/actions/runs/116986742

[pmcmaw]

This was also tested on concat and agent installed with no issues.

[DavidS]

This is a workaround for https://tickets.puppetlabs.com/browse/BOLT-1296. See puppetlabs/bolt#1337 for details.

[scotje]

@DavidS These deps have made the latest puppet_litmus releases not installable when PDK is building packages for Windows. (ed25519 gem fails to compile)

Is that expected? Do we need to pin litmus to 0.18.1 in PDK packaging for now?

[DavidS]

I should have expected that 🤦

The real solution would be to fix puppet-runtime to make ed25519 installable on windows - that would resolve this and bolt's problem.

To paper over it, we (IAC) can move the dependency from here (where it is platform-agnostic) to puppet-module-gems and exclude it from windows systems. We've already got a PMG update in the works and can add that on top. that should land early next week.

does that work for you?

[DavidS]

Created IAC-896 to track this