Make InventoryManipulation available to all rake tasks #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
========================================
+ Coverage 55.3% 55.6% +0.3%
========================================
Files 6 6
Lines 660 660
========================================
+ Hits 365 367 +2
+ Misses 295 293 -2
Continue to review full report at Codecov.
|
* fix new and updated rules * hardcode version numbers for dependabot to keep failures out of other PRs
Previously this was guarded by the existence of a inventory.yaml file, which could lead to errors when trying to chain operations: ``` ~/git/puppetlabs-motd$ rm inventory.yaml ~/git/puppetlabs-motd$ bundle exec rake litmus:provision[docker,litmusimage/debian:9] litmus:install_agent litmus:install_module Provisioning litmusimage/debian:9 using docker provisioner.[✔] localhost:2223, litmusimage/debian:9 rake aborted! NameError: undefined local variable or method `inventory_hash_from_inventory_file' for main:Object /home/david/gems/ruby/2.5.0/gems/puppet_litmus-0.15.0/lib/puppet_litmus/rake_tasks.rb:104:in `block (2 levels) in <top (required)>' /home/david/gems/ruby/2.5.0/gems/rake-12.3.3/exe/rake:27:in `<top (required)>' Tasks: TOP => litmus:install_agent (See full trace by running task with --trace) ~/git/puppetlabs-motd$ ```
DavidS
force-pushed
the
fix-inventorymanipulation-chaining
branch
from
113ede2 to
755607b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was guarded by the existence of a inventory.yaml file,
which could lead to errors when trying to chain operations: