Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) - new rake task to add a given feature to a group of nodes #236

Merged
merged 1 commit into from
Jan 30, 2020
Merged

(feat) - new rake task to add a given feature to a group of nodes #236

merged 1 commit into from
Jan 30, 2020

Conversation

david22swan
Copy link
Member

No description provided.

@david22swan david22swan requested a review from a team as a code owner January 28, 2020 12:51
@david22swan david22swan force-pushed the feature_add branch 4 times, most recently from dffc21a to 30fe767 Compare January 28, 2020 14:53
@david22swan
Copy link
Member Author

Attempted to add spec test's but running them caused the creation of an inventory file that then caused failures.

@DavidS
Copy link
Contributor

DavidS commented Jan 30, 2020

add calling the task with a test feature to

puppet_litmus/.travis.yml

Line 39 in 21fbe4f

BUNDLE_GEMFILE=./Gemfile bundle exec rake 'litmus:install_agent'
- that'll at least run the code once

@david22swan
Copy link
Member Author

@DavidS Have add the call and also place a check in the method for if no feature is given

@DavidS DavidS merged commit 201ddcd into puppetlabs:master Jan 30, 2020
@DavidS DavidS added the feature label Jan 30, 2020
@david22swan david22swan deleted the feature_add branch January 13, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidS DavidS DavidS approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david22swan @DavidS