[Backport 7.x] (#9292) New command line flag for puppet resource, fail #9300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See discussion in issue puppetlabs#9292. What this PR adds is the ability for on the command line if --fail is passed then the `puppet resource` command will exit with a non zero return code. (cherry picked from commit cf6cb77) Conflicts: lib/puppet/application/resource.rb spec/unit/application/resource_spec.rb We no longer need to call save_result.first, because we explicitly assign the save_result and report return values from save_result, report = Puppet::Resource.indirection.save(resource, key) Spec test conflict was because commit 65bcabd moved the test type and provider outside of the test.
tvpartytonight
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in issue #9292.
What this PR adds is the ability for on the command line if --fail is passed then the
puppet resourcecommand will exit with a non zero return code.(cherry picked from commit cf6cb77)
Conflicts:
lib/puppet/application/resource.rb
spec/unit/application/resource_spec.rb
We no longer need to call save_result.first, because we explicitly assign the save_result and report return values from
Spec test conflict was because commit 65bcabd moved the test type and provider outside of the test.