Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #9224: Add assumeyes option to dnf module list #9225

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fixes #9224: Add assumeyes option to dnf module list #9225

merged 1 commit into from
Mar 1, 2024

Conversation

loopiv
Copy link
Contributor

@loopiv loopiv commented Jan 26, 2024

No description provided.

@loopiv loopiv requested a review from a team as a code owner January 26, 2024 14:47
@puppetlabs-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@loopiv
Copy link
Contributor Author

loopiv commented Jan 26, 2024

See #9224

joshcooper
joshcooper approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree it's consistent with the rest of the dnf commands that the provider executes

@joshcooper
Copy link
Contributor

Can you rebase your changes on main to pickup a fix for Windows spec tests

@loopiv loopiv force-pushed the 9224-dnfmodule-gpgkey-issue branch from 2abd116 to 69b286c Compare February 1, 2024 15:26
@loopiv
Copy link
Contributor Author

loopiv commented Feb 1, 2024

Can you rebase your changes on main to pickup a fix for Windows spec tests

Rebased and pushed.

cthorn42
cthorn42 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@cthorn42 cthorn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loopiv thank you for the contribution.

@cthorn42 cthorn42 merged commit d9d07d2 into puppetlabs:main Mar 1, 2024
9 checks passed
@cthorn42 cthorn42 added the backport 7.x Generate a backport PR to 7.x label Mar 1, 2024
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Successfully created backport PR for 7.x:

@joshcooper joshcooper added the bug Something isn't working label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthorn42 cthorn42 cthorn42 approved these changes

@joshcooper joshcooper joshcooper approved these changes

Assignees
No one assigned
Labels
backport 7.x Generate a backport PR to 7.x bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loopiv @puppetlabs-jenkins @joshcooper @cthorn42