Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-5715) Download release tarballs for libxml2 and libxslt #827

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

joshcooper
Copy link
Contributor

@joshcooper joshcooper commented Apr 16, 2024

These changes make it possible for anyone to build the agent-runtime-* projects for modern linux outside of our network. This is done by installing the release tarballs from libxml2 and libxslt and installing the necessary packages to decompress the tarballs. And this will make it possible to easily bump to newer versions of libxml2 and libxslt in the future.

This is needed so that we can decompress libxml2 and libxslt release tarballs.

On Solaris 10/11, install xz 5.2.8 to match what was done in opencsw[1].
On AIX 7.1, we install 5.2.5, because that's what we have available.
On AIX 7.2, we install 5.4.3, since other packages we're installing depend on
that version.

Also update PATH on AIX and Solaris to refer to the version we installed.

[1] https://buildfarm.opencsw.org/source/xref/opencsw/csw/mgar/pkg/xz/trunk/Makefile?r=27065
Previously, we were using internally hosted libxml2 and libxslt tarballs to
work around the fact that upstream source tarballs don't contain a configure
script.

There are two different issues preventing us from generating the configure
script:

1. libxml2's configure.ac added a requirement on automake 1.16 to resolve an
   issue when building using python, but not all of our systems have 1.16 available:

    AM_INIT_AUTOMAKE([1.16.3 foreign no-dist-gzip dist-xz])

2. We explicitly disable python, so the automake 1.16.3 requirement isn't
   actually needed:

    ./configure --prefix=/opt/puppetlabs/puppet --without-python ...

In theory we could patch configure.ac and run `autoreconf -fi`, but we don't
have new enough libtool installed on all of our systems.

So just install the release tarballs that do contain a configure script.
@joshcooper joshcooper force-pushed the libxml2_release_tarball branch from 901679d to b4fe378 Compare April 17, 2024 04:08
@mhashizume mhashizume merged commit 436024a into puppetlabs:master Apr 17, 2024
3 checks passed
@joshcooper joshcooper added the bug Something isn't working label Apr 18, 2024
@joshcooper joshcooper deleted the libxml2_release_tarball branch April 18, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants