This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
(PE-38079) Gem updates to prepare for upcomming pe release #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://perforce.slack.com/archives/C04J7N6R761/p1712944816146219 |
donoghuc
force-pushed
the
PE-38079
branch
2 times, most recently
from
April 12, 2024 23:48
eb5c4e7
to
d9b5c53
Compare
This commit updates runtimes that package up bolt with latest gem dependencies. This includes bolt packages, bolt/ace server, and installer packages.
I built bolt and bolt server packages with these changes. i think we are in a good place to merge. I'll help keep an eye on components that consume runtime gems. |
tlehman
approved these changes
Apr 15, 2024
mhashizume
reviewed
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've seen issues with Facter and FFI >= 1.16.0 so we've pinned to 1.15.5 in both Facter and Puppet.
We are planning to resolve these issues this quarter in FACT-3434, could we hold off on the bump til then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, sorry ffi revert #825
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.