This repository has been archived by the owner on Sep 24, 2019. It is now read-only.
(maint) Ensure handle_puppet_run_returned_exit_code can use a Range #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if none of the catch_* and expect_* options where set the get_acceptable_puppet_run_exit_codes method would emit a Range (0..256). However this raised errors in the handle_puppet_run_returned_exit_code method because you cannot do a `.join` on a Range. This commit changes the output if it as an array; Joining if it is an array and converting to a string for other types. Tests have been added for this behavior.
Previously the spec tests assumed that the testing platform was Linux/Mac. This meant the local_runner tests failed on Windows. This commit guards the linux/Mac specific tests to not run on Windows.
glennsarti
force-pushed
the
use-an-array
branch
from
3172cd1 to
6c97f4a
Compare
glennsarti
changed the title
This commit fixes the various rubocop violations in the codebase.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if none of the catch_* and expect_* options where set the
get_acceptable_puppet_run_exit_codes method would emit a Range (0..256). However
this raised errors in the handle_puppet_run_returned_exit_code method because
you cannot do a
.joinon a Range. This commit changes the output if it as anarray; Joining if it is an array and converting to a string for other types.
Tests have been added for this behavior.