Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the "Extracting..." log for tar files #5741

Closed
timvandermeij opened this issue Apr 26, 2020 · 1 comment
Closed

Remove the "Extracting..." log for tar files #5741

timvandermeij opened this issue Apr 26, 2020 · 1 comment

Comments

@timvandermeij
Copy link

I'm introducing Puppeteer for Mozilla's PDF.js project in mozilla/pdf.js#11807. We write the output of test commands to log files and noticed that the logs are spammed with "Extracting..." logs when installing Firefox. I found that the origin of this is https://github.com/puppeteer/puppeteer/blame/1a4e2604588276945bbe5d02f7202fd735aaf522/src/BrowserFetcher.ts#L346 and it's unfortunately not configurable, so we have to hack around it now to remove all output from Firefox installation from the logs.

Could you remove that log since the extraction of zip files for example also doesn't log that?

/cc @mjzffr since it was introduced in #5467
@timvandermeij timvandermeij mentioned this issue Apr 26, 2020
Merged
mjzffr added a commit to mjzffr/puppeteer that referenced this issue May 31, 2020
@mjzffr
chore: Remove "Extracting..." log message
2603cb1 
Fixes puppeteer#5741
mjzffr added a commit to mjzffr/puppeteer that referenced this issue Jun 2, 2020
@mjzffr
chore: Remove "Extracting..." log message
48702d6 
Fixes puppeteer#5741
mathiasbynens pushed a commit that referenced this issue Jun 12, 2020
@mjzffr @mathiasbynens
chore: add test configuration options for running tests against multi…
3d56a9e 
…ple products (#5964)

* chore: remove "Extracting..." log message

Fixes #5741.

* test: support extra Launcher options and skips

The extra Launcher options and skipping conditions enable
unit tests to be run more easily by third-parties, e.g.
browser vendors that are interested in Puppeteer support.

Extra Launcher options were previously removed as part of
switching away from the custom test harness.

* test: enable more tests for Firefox
@timvandermeij
Copy link
Author

Thank you for fixing this!

@timvandermeij timvandermeij mentioned this issue Jun 12, 2020
Closed
timvandermeij added a commit to timvandermeij/pdf.js that referenced this issue Jul 26, 2020
@timvandermeij
Remove extraction log suppression code for Puppeteer
650a5c7 
This problem was fixed upstream in puppeteer/puppeteer#5741.
timvandermeij added a commit to timvandermeij/pdf.js that referenced this issue Jul 26, 2020
@timvandermeij
Remove extraction log suppression code for Puppeteer
063e18d 
This problem was fixed upstream in puppeteer/puppeteer#5741.
timvandermeij added a commit to timvandermeij/pdf.js that referenced this issue Jul 26, 2020
@timvandermeij
Remove extraction log suppression code for Puppeteer
8c43bea 
This problem was fixed upstream in puppeteer/puppeteer#5741.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timvandermeij