-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selects are not respecting the initial value #21
Comments
This works with optgroups as well. Fixes pupeno#21.
Working on this right now - looks like you snuck in a commit just before I pushed ;) I'll resolve the conflict and submit a PR. |
Awesome. Are you working with the free-form-examples? You can put free-forms in checkouts and it makes for a nice develop environment. I'm now going to go back to work on dashmantech/reagent-toolbox and dashmantech/reagent-toolbox-playground and once that's done I'll add Reagent Toolbox support to Free Form and that'll be release 0.6.0. |
No, but I ought to. Looks like my commit doesn't actually work outside of the tests... I'm nearly outa time here, but maybe it's a quick-fix. |
Yeah, the tests are not very good. It's hard to write good tests for a
library such as this.
…On 5 February 2017 at 17:46, Scott Bauer ***@***.***> wrote:
No, but I ought to. Looks like my commit doesn't actually work outside of
the tests... I'm nearly outa time here, but maybe it's a quick-fix.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAg6ZC9MgI6j2fpCTkbnnDkqZ0hObsRks5rZgr3gaJpZM4JqpvA>
.
--
J. Pablo Fernández <[email protected]> (http://pupeno.com)
|
Turns out my commit does work, I just had a bracket in the wrong place in my test project. I believe I found an issue w/ the checkbox/radio button code though - I'm almost positive that |
https://github.com/pupeno/free-form/blob/master/test/cljs/free_form/core_test.cljs#L176-L177
The text was updated successfully, but these errors were encountered: