Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selects are not respecting the initial value #21

Open
pupeno opened this issue Aug 23, 2016 · 5 comments
Open

Selects are not respecting the initial value #21

pupeno opened this issue Aug 23, 2016 · 5 comments

Comments

@pupeno
Copy link
Owner

pupeno commented Aug 23, 2016

https://github.com/pupeno/free-form/blob/master/test/cljs/free_form/core_test.cljs#L176-L177

Bauerpauer added a commit to wiecklabs/free-form that referenced this issue Feb 5, 2017
This works with optgroups as well. Fixes pupeno#21.
@Bauerpauer
Copy link
Contributor

Working on this right now - looks like you snuck in a commit just before I pushed ;) I'll resolve the conflict and submit a PR.

@pupeno
Copy link
Owner Author

pupeno commented Feb 5, 2017

Awesome. Are you working with the free-form-examples? You can put free-forms in checkouts and it makes for a nice develop environment. I'm now going to go back to work on dashmantech/reagent-toolbox and dashmantech/reagent-toolbox-playground and once that's done I'll add Reagent Toolbox support to Free Form and that'll be release 0.6.0.

@Bauerpauer
Copy link
Contributor

No, but I ought to. Looks like my commit doesn't actually work outside of the tests... I'm nearly outa time here, but maybe it's a quick-fix.

@pupeno
Copy link
Owner Author

pupeno commented Feb 5, 2017 via email

@Bauerpauer
Copy link
Contributor

Turns out my commit does work, I just had a bracket in the wrong place in my test project. I believe I found an issue w/ the checkbox/radio button code though - I'm almost positive that :default-checked should be :checked instead, since we're controlling the "checkedness" through the bound form map. Also, radio buttons (as I implemented them) apparently don't work properly with non-string values. Not sure if this is something that's important to support, but it's good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants