-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DropTarget hint and DropHighlightAdorner background brush #489
base: develop
Are you sure you want to change the base?
DropTarget hint and DropHighlightAdorner background brush #489
Conversation
…orner. This can be set through DropTargetHighlightBrushProperty. Updated TreeViewSample background brush in right Right TreeView
… to internal cache. Updated SettingsView to set this property
…ler. Extended doc for DropInfo.DestinationText
@punker76 any chance you are able to take a look at this PR in the near future? Happy Easter |
@bsundsbo I will take a look in next days |
Hi @mangoyoga80, I've finally had a look at your changes! I really like the feature. I only have one concern at the moment. Since an adorner is also used here for highlighting, the DropTargetAdorner is now always behind the HighlightAdorner. This cannot be prevented, as in WPF all adorners always get the same zIndex in the AdornerLayer. But I already have an idea how we can get this under control. Perhaps I will first adopt your changes and then build my idea on them. But in any case, thanks for your contribution here!!! /cc @bsundsbo |
I've not seen that issue as I've not used similar scenarios. Great you have some ideas how to fix. |
What changed?
DropTargetAdorner
with null check and some base propertiesFeature DropTargetHighlightBrush
dd:DragDrop.DropTargetHighlightBrush
.Feature DropHint
dd:DragDrop.UseDropTargetHint
to enable the featuredd:DragDrop.DropHintDataTemplate
to override datatemplate for displaying hintDragDrop.TryGetDropHandler
andDragDrop.TryGetDropInfoBuilder
internalIDropTarget.DropHint
and new properties onIDropInfo
which may be breaking changedd:DragDrop.UseDropTargetHint
added in SettingsView to enable for all demos using these settingsClosed issues.
#487 Added drop target hints
#488 Added the ability to change the brush of hint adorner.